Skip to content

Fixed p0 comment

Placeholder MINDY.L requested to merge codex/fix-octopus-import-p0 into feature/squid-import-project

Summary

  • Hardened Octopus import confirmation with aggregate permission checks derived from the server-parsed resource graph, project-conflict tampering validation, and explicit unsupported handling for Team and Machine.
  • Made import completion atomic by persisting successful session results inside the resource transaction, using cancellation-independent rollback and failure recording, and always clearing the EF change tracker after rollback.
  • Preserved multi-channel imports by reusing the auto-created default channel only for the source default and creating additional channels through CreateChannelCommand with correct ID mappings.
  • Redacted archive passwords and content streams from LoggerSpecification, with regression coverage for sensitive logging, permissions, validation, cancellation rollback, channel creation, and transaction atomicity.

This summary covers commit af2abdf7 relative to origin/feature/squid-import-project. Local changes to API configuration and docs/octopus-import-api.md are not included.

Test plan

  • dotnet build tests/Squid.UnitTests/Squid.UnitTests.csproj --no-restore -m:1 -nodeReuse:false --verbosity:minimal
  • dotnet build tests/Squid.IntegrationTests/Squid.IntegrationTests.csproj --no-restore -m:1 -nodeReuse:false --verbosity:minimal
  • git diff --check

Merge request reports