Skip to content

Fix variable set name and add extended action integration coverage

Placeholder MINDY.L requested to merge codex/octopus-import-real-fixture-validation into feature/squid-import-project

Summary

  • Added archive-backed integration coverage in OctopusImportExtendedActionFixtureIntegrationTests for Octopus.KubernetesDeployRawYaml, Octopus.HelmChartUpgrade, and Octopus.TentaclePackage, using a standard export ZIP with manifest hashes and validating preview, confirmation, PostgreSQL persistence, mapped properties, and action ID mappings.
  • Updated OctopusImportConfirmationOrchestrator.UpdateProjectVariableSetAsync to pass the destination project.Name into UpdateVariableSetCommand, preventing imported project variable sets from writing a NULL name and failing the database constraint.
  • Strengthened OctopusImportConfirmationOrchestratorTests to verify the mapper receives the project name and that the resulting UpdateVariableSetCommand.Name remains populated.
  • The fix remains scoped to Octopus import; shared VariableService behavior is unchanged.

Test plan

  • OctopusImportExtendedActionFixtureIntegrationTests.ArchiveImport_WithOfficialRawYamlHelmAndTentaclePackageShapes_PersistsMappedActions — 1 passed.
  • OctopusImportConfirmationOrchestratorTests — 12 passed after the final assertion was added.
  • Extended action mapper, registry, deployment-process mapper, and orchestrator regression filter — 49 passed.
  • OctopusImportDeploymentIntegrationTests.ArchiveImport_ImportedProjectProcessAndScopedVariables_CanCompleteDeployment — 1 passed.
  • Release builds for Squid.UnitTests and Squid.IntegrationTests — 0 errors; existing warnings remain.
  • git diff --check passed, and no new PostgreSQL constraint failures were observed after the fix.

Merge request reports